Message 380198 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	serhiy.storchaka
Recipients	erlendaasland, serhiy.storchaka
Date	2020-11-02.09:02:42
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
Are all these occurrences in the module initialization code? I think there is nothing wrong with this. Yes, the code can be a little clearer if use PyObject_GetArrt or PyModule_Add*, but rewriting can introduce new bugs. The remark in the documentation is rather about reading the module attributes and writing a new code. It does not require rewriting existing code. You can do this, but it will be treated as pure cosmetic change. It can be accepted if the new code is much clearer.

Are all these occurrences in the module initialization code?

I think there is nothing wrong with this. Yes, the code can be a little clearer if use PyObject_GetArrt or PyModule_Add*, but rewriting can introduce new bugs.

The remark in the documentation is rather about reading the module attributes and writing a new code. It does not require rewriting existing code.

You can do this, but it will be treated as pure cosmetic change. It can be accepted if the new code is much clearer.

History
Date	User	Action	Args
2020-11-02 09:02:42	serhiy.storchaka	set	recipients: + serhiy.storchaka, erlendaasland
2020-11-02 09:02:42	serhiy.storchaka	set	messageid: <[email protected]>
2020-11-02 09:02:42	serhiy.storchaka	link	issue42243 messages
2020-11-02 09:02:42	serhiy.storchaka	create