Message 221212 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	rhettinger
Recipients	Claudiu.Popa, r.david.murray, rhettinger, serhiy.storchaka
Date	2014-06-22.01:35:28
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<[email protected]>
In-reply-to

Content
The core idea is reasonable. The patch overreaches by adding readonly warnings to __setitem__ and __delitem__ which will spew-out on every call (these could be ignored or set to warn once by the user but that is PITA). Minor nit. We have a little PEP-8 overkill on the string splits: + with self.assertWarnsRegex(DeprecationWarning, + "The database file is missing, the " + "semantics of the 'c' flag will " + "be used."):

The core idea is reasonable.  

The patch overreaches by adding readonly warnings to __setitem__ and __delitem__ which will spew-out on every call (these could be ignored or set to warn once by the user but that is PITA).

Minor nit.  We have a little PEP-8 overkill on the string splits:

+            with self.assertWarnsRegex(DeprecationWarning,
+                                       "The database file is missing, the "
+                                       "semantics of the 'c' flag will "
+                                       "be used."):

History
Date	User	Action	Args
2014-06-22 01:35:29	rhettinger	set	recipients: + rhettinger, r.david.murray, Claudiu.Popa, serhiy.storchaka
2014-06-22 01:35:29	rhettinger	set	messageid: <[email protected]>
2014-06-22 01:35:29	rhettinger	link	issue21708 messages
2014-06-22 01:35:28	rhettinger	create