Message 143360 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	python-dev, rosslagerwall, vstinner
Date	2011-09-01.21:57:18
SpamBayes Score	2.51063e-07
Marked as misclassified	No
Message-id	<[email protected]>
In-reply-to

Content
> The second patch looks good. Tests? I don't see how to test that the pipes are closed, because the Popen object (and its stdout and stderr attributes) are not visible outside the patched functions. > I consider that this issue is a bug, so it should be fixed in 2.7 > and 3.2. I tried to write a patch, but I chose to keep the code unchanged. I prefer to keep this little tricky bug, instead of introducing another more important regression. Reopen the issue if you have a script to test the fix, or if you really want a backport.

> The second patch looks good. Tests?

I don't see how to test that the pipes are closed, because the Popen object (and its stdout and stderr attributes) are not visible outside the patched functions.

> I consider that this issue is a bug, so it should be fixed in 2.7
> and 3.2.

I tried to write a patch, but I chose to keep the code unchanged. I prefer to keep this little tricky bug, instead of introducing another more important regression.

Reopen the issue if you have a script to test the fix, or if you really want a backport.

History
Date	User	Action	Args
2011-09-01 21:57:19	vstinner	set	recipients: + vstinner, rosslagerwall, python-dev
2011-09-01 21:57:19	vstinner	set	messageid: <[email protected]>
2011-09-01 21:57:18	vstinner	link	issue12494 messages
2011-09-01 21:57:18	vstinner	create