Debian Bug report logs - #800797
docbook-utils: please generate reproducible manpages

Display info messages

Message #5 received at [email protected] (full text, mbox, reply):

From: Reiner Herrmann <[email protected]>

To: [email protected]

Subject: docbook-utils: please generate reproducible manpages

Date: Sat, 03 Oct 2015 19:31:04 +0200

[Message part 1 (text/plain, inline)]

Source: docbook-utils
Version: 0.6.14-3
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: toolchain timestamps locale
X-Debbugs-Cc: [email protected]

Hi!

While working on the "reproducible builds" effort [1], we have noticed
that docbook-utils doesn't generate reproducible manpages.
The embedded timestamp is using the build date and also varies depending
on the configured locale.

The attached patch adds support for the SOURCE_DATE_EPOCH environment
variable [2] and uses the C locale for the human-readable month
(which also fixes #214982).

Regards,
 Reiner

[1]: https://wiki.debian.org/ReproducibleBuilds
[2]: https://reproducible-builds.org/specs/source-date-epoch/

[docbook-utils.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Message #10 received at [email protected] (full text, mbox, reply):

From: intrigeri <[email protected]>

To: [email protected]

Cc: Reiner Herrmann <[email protected]>

Subject: Re: Bug#800797: docbook-utils: please generate reproducible manpages

Date: Fri, 03 Jun 2016 15:58:55 +0200

Hi Debian XML/SGML Group!

Reiner Herrmann wrote (03 Oct 2015 17:31:04 GMT) :
> While working on the "reproducible builds" effort [1], we have noticed
> that docbook-utils doesn't generate reproducible manpages.
> The embedded timestamp is using the build date and also varies depending
> on the configured locale.

... and indeed, this makes the "wpa" package unreproducible (that's
how I've ended up here, looking for packages we ship in Tails that are
not reproducible yet).

> The attached patch adds support for the SOURCE_DATE_EPOCH environment
> variable [2] and uses the C locale for the human-readable month
> (which also fixes #214982).

FWIW, I've reviewed this patch with my Perl developer hat, and it
looks good to me. I have not tested myself whether it actually fixes
the problem at hand, but I'm sure that Reiner has done that
before submitting.

Dear maintainers, what would be your preferred course of action? I see
no upload since 2012, and this patch was proposed 8 months ago, so
perhaps you wouldn't mind a non-maintainer upload applying it?

Cheers,
--
intrigeri

Message #15 received at [email protected] (full text, mbox, reply):

From: Guido Günther <[email protected]>

To: Reiner Herrmann <[email protected]>, [email protected]

Subject: Re: Bug#800797: docbook-utils: please generate reproducible manpages

Date: Sun, 3 Jul 2016 13:19:44 +0200

On Sat, Oct 03, 2015 at 07:31:04PM +0200, Reiner Herrmann wrote:
> Source: docbook-utils
> Version: 0.6.14-3
> Severity: wishlist
> Tags: patch
> User: [email protected]
> Usertags: toolchain timestamps locale
> X-Debbugs-Cc: [email protected]
> 
> Hi!
> 
> While working on the "reproducible builds" effort [1], we have noticed
> that docbook-utils doesn't generate reproducible manpages.
> The embedded timestamp is using the build date and also varies depending
> on the configured locale.
> 
> The attached patch adds support for the SOURCE_DATE_EPOCH environment
> variable [2] and uses the C locale for the human-readable month
> (which also fixes #214982).
> 
> Regards,
>  Reiner
> 
> [1]: https://wiki.debian.org/ReproducibleBuilds
> [2]: https://reproducible-builds.org/specs/source-date-epoch/
> 

> diff --git a/debian/patches/series b/debian/patches/series
> index 6e5630a..795b9d1 100644
> --- a/debian/patches/series
> +++ b/debian/patches/series
> @@ -4,3 +4,4 @@ bug_212088.patch
>  bug_214982.patch
>  bug_394511.patch
>  bug_528334.patch
> +support_source_date_epoch.patch
> diff --git a/debian/patches/support_source_date_epoch.patch b/debian/patches/support_source_date_epoch.patch
> new file mode 100644
> index 0000000..ce5559c
> --- /dev/null
> +++ b/debian/patches/support_source_date_epoch.patch
> @@ -0,0 +1,29 @@
> +Author: Reiner Herrmann <[email protected]>
> +Description: Support SOURCE_DATE_EPOCH for timestamps
> + To allow generating documents in a reproducible way,
> + allow overriding the timestamp through the environment.
> + .
> + See also: https://reproducible-builds.org/specs/source-date-epoch/
> +
> +Index: docbook-utils-0.6.14/helpers/docbook2man-spec.pl
> +===================================================================
> +--- docbook-utils-0.6.14.orig/helpers/docbook2man-spec.pl
> ++++ docbook-utils-0.6.14/helpers/docbook2man-spec.pl
> +@@ -57,6 +57,7 @@ Software Foundation, 675 Mass Ave, Cambr
> + use SGMLS;			# Use the SGMLS package.
> + use SGMLS::Output;		# Use stack-based output.
> + use SGMLS::Refs;
> ++use POSIX qw(strftime setlocale LC_TIME);
> + 
> + ########################################################################
> + # SGMLSPL script produced automatically by the script sgmlspl.pl
> +@@ -278,7 +279,8 @@ sgml('</REFMETA>', sub {
> + .\\" etc. to Steve Cheng <steve\@ggi-project.org>.
> + _END_BANNER
> + 
> +-	my $date = `date "+%d %B %Y"`;
> ++	setlocale(LC_TIME, "C");

Would it make sense to force the C locale only if SOURCE_DATE_EPOCH is
set to not modify existing behaviour? Otherwise I'm all for an NMU.
Cheers,
 -- Guido

Message #22 received at [email protected] (full text, mbox, reply):

From: Reiner Herrmann <[email protected]>

To: Guido Günther <[email protected]>

Cc: [email protected]

Subject: Re: Bug#800797: docbook-utils: please generate reproducible manpages

Date: Mon, 4 Jul 2016 11:03:35 +0200

[Message part 1 (text/plain, inline)]

On Sun, Jul 03, 2016 at 01:19:44PM +0200, Guido Günther wrote:
> Would it make sense to force the C locale only if SOURCE_DATE_EPOCH is
> set to not modify existing behaviour? Otherwise I'm all for an NMU.

Yes, that makes sense.  I attached an updated patch, which behaves as
before if SOURCE_DATE_EPOCH is not set.

Regards,
  Reiner

[docbook-utils.patch (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #27 received at [email protected] (full text, mbox, reply):

From: Reiner Herrmann <[email protected]>

To: [email protected]

Subject: docbook-utils: diff for NMU version 0.6.14-3.1

Date: Mon, 4 Jul 2016 16:22:56 +0200

[Message part 1 (text/plain, inline)]

Control: tags 800797 + patch
Control: tags 800797 + pending

Dear maintainer,

I've prepared an NMU for docbook-utils (versioned as 0.6.14-3.1) and
uploaded it to DELAYED/15. Please feel free to tell me if I
should delay it longer.

Regards.
 Reiner

[docbook-utils-0.6.14-3.1-nmu.diff (text/x-diff, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #34 received at [email protected] (full text, mbox, reply):

From: Reiner Herrmann <[email protected]>

To: [email protected]

Subject: Bug#800797: fixed in docbook-utils 0.6.14-3.1

Date: Tue, 19 Jul 2016 16:05:06 +0000

Source: docbook-utils
Source-Version: 0.6.14-3.1

We believe that the bug you reported is fixed in the latest version of
docbook-utils, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Reiner Herrmann <[email protected]> (supplier of updated docbook-utils package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 04 Jul 2016 13:59:43 +0200
Source: docbook-utils
Binary: docbook-utils
Architecture: source
Version: 0.6.14-3.1
Distribution: unstable
Urgency: low
Maintainer: Debian XML/SGML Group <[email protected]>
Changed-By: Reiner Herrmann <[email protected]>
Description:
 docbook-utils - Convert DocBook files to other formats (HTML, RTF, PS, man, PDF)
Closes: 800797
Changes:
 docbook-utils (0.6.14-3.1) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Add patch to honour SOURCE_DATE_EPOCH to enable reproducible
     building of manpages. Closes: #800797
   * Import changes from Ubuntu:
     - Make docbook-utils Multi-Arch: foreign. LP: #950886
Checksums-Sha1:
 bb10b8cdfa42c30271a9942219f5ed6ce8cce984 2113 docbook-utils_0.6.14-3.1.dsc
 da6d0f9f7e47a5f5bfcef32fcdf4d81e9a7bb208 11776 docbook-utils_0.6.14-3.1.debian.tar.xz
Checksums-Sha256:
 a30f11e93808386b7e4e599cb8f74bf55e0888f8ffd1b2d11e56e249801342d7 2113 docbook-utils_0.6.14-3.1.dsc
 ec90bf0fd58112acc7baa7a291132c7a0254d4e168e53c75242538ef60ce9810 11776 docbook-utils_0.6.14-3.1.debian.tar.xz
Files:
 8c74a148512e2458655e9a6505583ccc 2113 text optional docbook-utils_0.6.14-3.1.dsc
 b1342d19e9ff2bfe65b1a81b63189e39 11776 text optional docbook-utils_0.6.14-3.1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJXem8wAAoJEEsEP825REVAYTEQAMim8iMm+tOw6HBY6wcMfH8+
jyWMJS17OCepHMBrzRxxbsPjMHLa21dpNupi7eA2r8TxogqAPw0cq7Cv5ZjH2fLo
o1svoSkurvWveixxBGx0JRkxnhwiEKwHG7vcfRKuC1kg+IpYke+us8emRCpE8veE
NgWq42r/T5GoNzXxEXJbhR56l6f0nFZ2wep8I66xbsHGFZcG++DeFLZF8WicMqOg
/z32lGtUh+zVFBc+EnQLxgtw16+c7NCjo6ridQbLcg+f2hSL1ieSNrvtvFzcwDBA
tfJBwkuaTJm3J7jN6uIXWGt8++3pr8NDEs5T3oeGtNqBjILAmphM7T2GKi+0Gfwg
3SW7r5QQinEpxzCUFlE4FAT/is74i7/ptuzhtBIKAQx2J8OakEhYPnSig344LrNT
/V+0E/ajSXr2BVZewoBIrf2oVScuXSZSzbDS5RU5mo3dP9tXjeXM26Jug1VryvxU
PClyn1okQgyUTk86patF2opH1JMKW8+lJ4XmVe427U4ScVmmnm8eQ0BK0UNOEXh6
MQCgefDGK0eVbbRtwox2Zttn6pecYLgzFB0V/AIvFcrBx50yASjhjUBZzlLlJGZ7
uu33DLeVme3Oz1uHEajodPRiq464DwzeRoK5EhK+aQ+3uPBxx+x2FKmCN9aYmTGc
IBoCFPDUHT+knrezWcwi
=vLkJ
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.