Skip to content

gh-50571: Check bytecode before accepting a breakpoint in pdb #145121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aisk wants to merge 13 commits into
base: main
Choose a base branch
from
Open

gh-50571: Check bytecode before accepting a breakpoint in pdb #145121

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
7df087e
Check bytecode before accepting a breakpoint in pdb
aisk Feb 22, 2026
2705463
Add news entry
aisk Feb 22, 2026
27fc63f
Using the fancy contextlib.suppress to suppress error
aisk Feb 22, 2026
c631e9f
Fix tests
aisk Feb 22, 2026
d244856
Update Misc/NEWS.d/next/Library/2026-02-23-00-58-24.gh-issue-50571.jZ…
aisk Feb 23, 2026
2c291f0
Update comments in test_bdb.py
aisk Feb 23, 2026
c4d4d7d
Check code object by isinstance
aisk Feb 23, 2026
026f62a
Add _executable_linenos_cache
aisk Feb 23, 2026
0c0f4fd
Move the _executable_linenos_cache to Bdb instance
aisk Feb 23, 2026
346eef2
Fix code style
aisk Feb 23, 2026
eaf71ac
Remove the _ prefix for executable_linenos_cache
aisk Feb 23, 2026
f83c060
Change executable_linenos_cache to global variable and add check cach…
aisk Feb 26, 2026
9d539db
Fix create tuple from string
aisk Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Check bytecode before accepting a breakpoint in pdb
  • Loading branch information
@aisk
aisk committed Feb 22, 2026
commit 7df087ee86f1d4dbd1ade3bf78499a4abc4723f1
20 changes: 20 additions & 0 deletions Lib/bdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,17 @@ def _get_lineno(self, code, offset):
return last_lineno


def _get_executable_linenos(code):
linenos = set()
for _, _, lineno in code.co_lines():
if lineno is not None:
linenos.add(lineno)
for const in code.co_consts:
if hasattr(const, 'co_lines'):
linenos |= _get_executable_linenos(const)
return linenos


class Bdb:
"""Generic Python debugger base class.

Expand Down Expand Up @@ -671,6 +682,15 @@ def set_break(self, filename, lineno, temporary=False, cond=None,
line = linecache.getline(filename, lineno)
if not line:
return 'Line %s:%d does not exist' % (filename, lineno)
source = ''.join(linecache.getlines(filename))
if source:
try:
code = compile(source, filename, 'exec')
executable_lines = _get_executable_linenos(code)
if executable_lines and lineno not in executable_lines:
return 'Line %d has no code associated with it' % lineno
except SyntaxError:
pass
self._add_to_breaks(filename, lineno)
bp = Breakpoint(filename, lineno, temporary, cond, funcname)
# After we set a new breakpoint, we need to search through all frames
Expand Down
16 changes: 16 additions & 0 deletions Lib/test/test_pdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4188,6 +4188,22 @@ def test_breakpoint(self):
self.assertTrue(any("Breakpoint 1 at" in l for l in stdout.splitlines()), stdout)
self.assertTrue(all("SUCCESS" not in l for l in stdout.splitlines()), stdout)

def test_breakpoint_on_no_bytecode_line(self):
script = """
x = 1
def f():
global x # line 4: no bytecode
x = 2
f()
"""
commands = """
b 4
c
quit
"""
stdout, _ = self.run_pdb_module(script, commands)
self.assertIn('no code', '\n'.join(stdout.splitlines()))

def test_run_pdb_with_pdb(self):
commands = """
c
Expand Down