Skip to content

Add a simple extended error message (#4646) #5568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
christianbender wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add a simple extended error message (#4646) #5568

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d375c3a
simple extended error message
Jul 1, 2018
3351997
changed mechanism
Jul 3, 2018
6aeaec5
add regex-method and tidy up the code
Jul 4, 2018
10f8624
removed some println`s
Jul 4, 2018
b00f689
modified the regex expression
Jul 4, 2018
a38f29c
modified the regex expression for proper error message
Jul 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed some println`s
  • Loading branch information
Christian Bender committed Jul 4, 2018
commit 10f8624971b9c9cba97b466cb613f6fc7ab886cf
9 changes: 1 addition & 8 deletions java/src/processing/mode/java/Compiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,9 @@ static public boolean compile(JavaBuild build) throws SketchException {
"-nowarn", // we're not currently interested in warnings (works in ecj)
"-d", build.getBinFolder().getAbsolutePath() // output the classes in the buildPath
};
//PApplet.println(baseCommand);

String[] sourceFiles = Util.listFiles(build.getSrcFolder(), false, ".java");
String[] command = PApplet.concat(baseCommand, sourceFiles);
//PApplet.println(command);

// System.out.printf("DEBUG: class Compiler -- BEGIN -- compile(...) exception=%s\n",exception); // DEBUG

try {
// Load errors into a local StringBuilder
Expand Down Expand Up @@ -193,7 +189,6 @@ public void close() { }
String[] m = PApplet.match(errorMessage, "The import (.*) cannot be resolved");
//what = what.substring(0, what.indexOf(' '));
if (m != null) {
// System.out.println("'" + m[1] + "'");
if (m[1].equals("processing.xml")) {
exception.setMessage("processing.xml no longer exists, this code needs to be updated for 2.0.");
System.err.println("The processing.xml library has been replaced " +
Expand Down Expand Up @@ -237,9 +232,7 @@ public void close() { }
}

} else if (errorMessage.endsWith("cannot be resolved")) {
// xxx cannot be resolved
//println(xxx);


String what = errorMessage.substring(0, errorMessage.indexOf(' '));

if (what.equals("LINE_LOOP") ||
Expand Down