feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24 by aladdin-add · Pull Request #297 · eslint/rewrite

aladdin-add · 2025-10-14T06:03:20Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request?

Updated package.json of the package to require:

"node": "^20.19.0 || ^22.13.0 || >=24"

This drops support for Node.js 18.

What changes did you make? (Give an overview)

Related Issues

refs eslint/eslint#19969

Is there anything you'd like reviewers to focus on?

mdjermanovic

Can you also update the template for new projects?

rewrite/templates/package/package.json

Lines 54 to 56 in 27fdbe7

    
           "engines": { 
        
             "node": "^18.18.0 || ^20.9.0 || >=21.1.0" 
        
           }

refs eslint/eslint#19969

mdjermanovic

LGTM, thanks!

SwetaTanwar · 2025-10-24T08:50:32Z

LGTM, thanks!

lumirlumir

rewrite/package.json

Lines 31 to 33 in 35f7342

    
           "engines": { 
        
             "node": ">= 22.3.0" 
        
           },

Could we also update the engines field in the root-level package.json?

I believe the engines field was first added in 973144e, but it seems fine to set it to ^20.19.0 || ^22.13.0 || >=24, since all internal Node.js modules used by the rewrite package are available with Node.js ^20.19.0.

mdjermanovic · 2025-10-30T13:12:35Z

I believe the engines field was first added in 973144e, but it seems fine to set it to ^20.19.0 || ^22.13.0 || >=24, since all internal Node.js modules used by the rewrite package are available with Node.js ^20.19.0.

This was added because of fs.cpSync(), which is used in tools/new-pkg.js.

lumirlumir · 2025-10-30T13:42:47Z

I missed that the stable version was released as v22.3.0 👍

If so, does using ^22.13.0 || >=24 make sense here? It seems a bit odd for me that the internal package.json and the root-level package.json use different engine versions.

aladdin-add · 2025-10-30T14:13:20Z

It seems a bit odd for me that the internal package.json and the root-level package.json use different engine versions.

IMHO, it's fine - they are different things - unlike others, the root-level act as something like devEngines : https://github.com/openjs-foundation/package-metadata-interoperability-collab-space/blob/main/devengines-field-proposal.md

lumirlumir · 2025-10-30T14:19:30Z

@aladdin-add Thanks for the reference!

If so, please feel free to revert my suggestion or set it to ^22.13.0 || >=24 depending on the consensus :)

lumirlumir

LGTM!

mdjermanovic

LGTM, thanks!

See-also: eslint/rewrite#297

This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@eslint/compat](https://github.com/eslint/rewrite/tree/main/packages/compat#readme) ([source](https://github.com/eslint/rewrite/tree/HEAD/packages/compat)) | devDependencies | major | [`^1.3.1` → `^2.0.0`](https://renovatebot.com/diffs/npm/@eslint%2fcompat/1.4.1/2.0.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/eslint/rewrite/badge)](https://securityscorecards.dev/viewer/?uri=github.com/eslint/rewrite) | --- ### Release Notes <details> <summary>eslint/rewrite (@eslint/compat)</summary> ### [`v2.0.0`](https://github.com/eslint/rewrite/blob/HEAD/packages/compat/CHANGELOG.md#200-2025-11-14) [Compare Source](eslint/rewrite@f5ecc7e...c368656) ##### ⚠ BREAKING CHANGES - Require Node.js ^20.19.0 || ^22.13.0 || >=24 ([#297](eslint/rewrite#297)) ##### Features - patch missing context and SourceCode methods for v10 ([#311](eslint/rewrite#311)) ([a40d8c6](eslint/rewrite@a40d8c6)) - Require Node.js ^20.19.0 || ^22.13.0 || >=24 ([#297](eslint/rewrite#297)) ([acc623c](eslint/rewrite@acc623c)) ##### Dependencies - The following workspace dependencies were updated - dependencies - [@eslint/core](https://github.com/eslint/core) bumped from ^0.17.0 to ^1.0.0 </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!234 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com>

chore(deps): update @eslint/compat (major) This MR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [@eslint/compat](https://github.com/eslint/rewrite/tree/main/packages/compat#readme) ([source](https://github.com/eslint/rewrite/tree/HEAD/packages/compat)) | devDependencies | major | [`^1.3.1` → `^2.0.0`](https://renovatebot.com/diffs/npm/@eslint%2fcompat/1.4.1/2.0.0) | [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/eslint/rewrite/badge)](https://securityscorecards.dev/viewer/?uri=github.com/eslint/rewrite) | --- ### Release Notes <details> <summary>eslint/rewrite (@eslint/compat)</summary> ### [`v2.0.0`](https://github.com/eslint/rewrite/blob/HEAD/packages/compat/CHANGELOG.md#200-2025-11-14) [Compare Source](eslint/rewrite@f5ecc7e...c368656) ##### ⚠ BREAKING CHANGES - Require Node.js ^20.19.0 || ^22.13.0 || >=24 ([#297](eslint/rewrite#297)) ##### Features - patch missing context and SourceCode methods for v10 ([#311](eslint/rewrite#311)) ([a40d8c6](eslint/rewrite@a40d8c6)) - Require Node.js ^20.19.0 || ^22.13.0 || >=24 ([#297](eslint/rewrite#297)) ([acc623c](eslint/rewrite@acc623c)) ##### Dependencies - The following workspace dependencies were updated - dependencies - [@eslint/core](https://github.com/eslint/core) bumped from ^0.17.0 to ^1.0.0 </details> --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  See merge request swiss-armed-forces/cyber-command/cea/loom!234 Co-authored-by: Loom MR Pipeline Trigger <group_103951964_bot_9504bb8dead6d4e406ad817a607f24be@noreply.gitlab.com> Co-authored-by: open-source Pipeline <group_90701827_bot_ed04ae348bc5f40af9966fb8b6867e99@noreply.gitlab.com>

github-project-automation bot added this to Triage Oct 14, 2025

eslint-github-bot bot added breaking feature labels Oct 14, 2025

github-project-automation bot moved this to Needs Triage in Triage Oct 14, 2025

aladdin-add mentioned this pull request Oct 14, 2025

Change Request: Update Node.js version support eslint/eslint#19969

Closed

1 task

aladdin-add moved this from Needs Triage to Blocked in Triage Oct 14, 2025

aladdin-add force-pushed the feat/drop-node-18 branch from 866d2df to 70cde5e Compare October 17, 2025 13:26

mdjermanovic reviewed Oct 19, 2025

View reviewed changes

aladdin-add added 3 commits October 19, 2025 22:31

feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24

d938a2a

refs eslint/eslint#19969

Update ci.yml

f931edb

Update Node.js version requirements in package.json

c6d1c20

aladdin-add force-pushed the feat/drop-node-18 branch from 2b56bea to c6d1c20 Compare October 19, 2025 14:31

fasttime added the accepted label Oct 20, 2025

mdjermanovic previously approved these changes Oct 20, 2025

View reviewed changes

SwetaTanwar previously approved these changes Oct 24, 2025

View reviewed changes

lumirlumir requested changes Oct 30, 2025

View reviewed changes

Update Node.js engine version requirements

8aec85d

aladdin-add dismissed stale reviews from SwetaTanwar and mdjermanovic via 8aec85d October 30, 2025 12:53

Modify Node.js version range in root-level package.json

8f94d51

lumirlumir approved these changes Oct 30, 2025

View reviewed changes

mdjermanovic approved these changes Nov 3, 2025

View reviewed changes

mdjermanovic marked this pull request as ready for review November 11, 2025 17:46

mdjermanovic merged commit acc623c into main Nov 11, 2025
25 checks passed

mdjermanovic deleted the feat/drop-node-18 branch November 11, 2025 17:46

github-project-automation bot moved this from Blocked to Complete in Triage Nov 11, 2025

github-actions bot mentioned this pull request Nov 11, 2025

chore: release main #317

Merged

hyunbinseo mentioned this pull request Nov 16, 2025

Update @eslint/compat to v2 sveltejs/cli#782

Closed

jgarber623-cargosense added a commit to CargoSense/eslint-config that referenced this pull request Dec 4, 2025

Update engines config to match eslint/compat

60a4573

See-also: eslint/rewrite#297

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24#297

feat!: Require Node.js ^20.19.0 || ^22.13.0 || >=24#297
mdjermanovic merged 5 commits intomainfrom
feat/drop-node-18

aladdin-add commented Oct 14, 2025

Uh oh!

mdjermanovic left a comment

Uh oh!

mdjermanovic left a comment

Uh oh!

SwetaTanwar commented Oct 24, 2025 •

edited

Loading

Uh oh!

lumirlumir left a comment

Uh oh!

mdjermanovic commented Oct 30, 2025

Uh oh!

lumirlumir commented Oct 30, 2025 •

edited

Loading

Uh oh!

aladdin-add commented Oct 30, 2025

Uh oh!

lumirlumir commented Oct 30, 2025

Uh oh!

lumirlumir left a comment

Uh oh!

mdjermanovic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

aladdin-add commented Oct 14, 2025

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

Related Issues

Is there anything you'd like reviewers to focus on?

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

SwetaTanwar commented Oct 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lumirlumir left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic commented Oct 30, 2025

Uh oh!

lumirlumir commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aladdin-add commented Oct 30, 2025

Uh oh!

lumirlumir commented Oct 30, 2025

Uh oh!

lumirlumir left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SwetaTanwar commented Oct 24, 2025 •

edited

Loading

lumirlumir commented Oct 30, 2025 •

edited

Loading