fix(drizzle): resolve join collisions in nested relationship queries#15593
Open
sumit8239 wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(drizzle): resolve join collisions in nested relationship queries#15593sumit8239 wants to merge 1 commit intopayloadcms:mainfrom
sumit8239 wants to merge 1 commit intopayloadcms:mainfrom
Conversation
edc9a74 to
21fe82a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Queries in the Drizzle adapter would fail when filtering across multiple relationship fields that target the same collection or have nested fields with identical names.
This happened because the constraintPath was being used as the join deduplication key (queryPath). However, constraintPath is reset to an empty string whenever a query "jumps" to a new collection via a relationship field. This led to different logical paths (e.g., artist.categories and organizer.categories) sharing the same join identifier, causing Drizzle to incorrectly reuse the same table alias for distinct joins.
Solution
I have implemented a more robust absolute path tracking mechanism:
Changes
Fixes #15585