Skip to content

STY: update example with preferred plt.subplots()#4356

Merged
tacaswell merged 1 commit into
matplotlib:masterfrom
mscross:examples_streamplot_feat
Apr 22, 2015
Merged

STY: update example with preferred plt.subplots()#4356
tacaswell merged 1 commit into
matplotlib:masterfrom
mscross:examples_streamplot_feat

Conversation

@mscross

@mscross mscross commented Apr 19, 2015

Copy link
Copy Markdown
Contributor
  • Edit first example in streamplot_demo_features.py to conform with preference for fig, ax = plt.subplots(), tweaking style of second example for consistency.
  • Add whitespace around / operator for readability (can revert this if preferred).

@tacaswell tacaswell added this to the next point release milestone Apr 19, 2015
@tacaswell

tacaswell commented Apr 19, 2015

Copy link
Copy Markdown
Member

👍 Looks good to me

@WeatherGod

WeatherGod commented Apr 20, 2015

Copy link
Copy Markdown
Member

Strange Travis failure:

======================================================================
FAIL: Github issue #1256 identified a bug in Line.draw method
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/nose/case.py", line 198, in runTest
    self.test(*self.arg)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/testing/decorators.py", line 110, in wrapped_function
    func(*args, **kwargs)
  File "/home/travis/virtualenv/python3.4.2/lib/python3.4/site-packages/matplotlib-1.5.dev1-py3.4-linux-x86_64.egg/matplotlib/tests/test_lines.py", line 58, in test_invisible_Line_rendering
    assert_true(slowdown_factor < slowdown_threshold)
AssertionError: False is not true

I doubt it has anything to do with this change.

@jenshnielsen

jenshnielsen commented Apr 20, 2015

Copy link
Copy Markdown
Member

@WeatherGod that one happens once in a while. My understanding is that it tries to measure performance which does somewhat depend on what else is running.

tacaswell added a commit that referenced this pull request Apr 22, 2015
@tacaswell
Merge pull request #4356 from mscross/examples_streamplot_feat
c85c67b 
STY : update streamplot_demo_features.py style
@tacaswell tacaswell merged commit c85c67b into matplotlib:master Apr 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mscross @tacaswell @WeatherGod @jenshnielsen