BUG/API : relax validation in hist#3883
Merged
Merged
Conversation
Relax the validation on input data to hist. - up-convert scalar to length 1 list - don't error out for length 1 input data closes matplotlib#3882
Member
|
LGTM is there any point in adding a test? |
Member
Author
|
Yes, good catch on me being lazy. |
jenshnielsen
added a commit
that referenced
this pull request
Dec 29, 2014
BUG/API : relax validation in hist
Member
Author
Member
|
I don't see any harm in including it in 1.4.x. But how long is this branch going to stay alive? Is there a compelling reason not to move on to 1.5.0? |
Member
Author
|
Well, in this case I am thinking about pulling it back for 1.4.3. Do we want to shut down 1.4.x and target 1.5.0 for scipy (modulo 2.0 due to colormap changes)? |
Member
|
If things going into 1.5.0 are not too revolutionary, then I don't see much point in having a long series of 1.4 bugfix releases, so I think shutting 1.4.x makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relax the validation on input data to hist.
closes #3882