Conversation
Signed-off-by: Asish Kumar <[email protected]>
officialasishkumar
requested review from
Sarthak160 and
gouravkrosx
as code owners
There was a problem hiding this comment.
Pull request overview
Updates the default integrations repository git ref used by the internal composite GitHub Action that fetches private parsers/dependencies during CI workflows.
Changes:
- Changed the default
inputs.integration-reffor.github/actions/setup-private-parsersfrommaintofix-atomic-mongo.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| integration-ref: | ||
| description: 'The git ref (branch, tag, or commit) of the integrations repo.' | ||
| required: true | ||
| default: 'main' | ||
| default: 'fix-atomic-mongo' |
There was a problem hiding this comment.
Changing the default integration-ref from main to a feature branch (fix-atomic-mongo) will implicitly affect all workflows that use this composite action without explicitly setting integration-ref (e.g. release/lint/docker workflows). This makes CI/release behavior depend on a potentially short-lived branch and can break builds if the branch is deleted/force-pushed. Prefer keeping the default as a stable ref (e.g. main or a tagged version/commit SHA) and, if a non-default ref is needed, pass integration-ref explicitly from the calling workflow(s) that require it.
officialasishkumar
force-pushed
the
sanity-check-integrations
branch
from
7c3795a to
b0fe08d
Compare
Signed-off-by: Asish Kumar <[email protected]>
officialasishkumar
force-pushed
the
sanity-check-integrations
branch
from
b0fe08d to
31de5cf
Compare
officialasishkumar
force-pushed
the
sanity-check-integrations
branch
from
e0971f1 to
7bb3ba6
Compare
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| required: false | ||
| type: string | ||
| default: 'main' # Use main branch if nothing is sent** | ||
| default: 'fix-atomic-mongo' # Use main branch if nothing is sent** |
There was a problem hiding this comment.
WARNING: Changing the default integration-ref from main to a feature branch fix-atomic-mongo.
- Inconsistent comment: The inline comment says "Use main branch if nothing is sent" but the default is now
fix-atomic-mongo - Risk: This changes the default behavior for all callers of this workflow. If this PR is merged, all workflows using this without explicitly specifying
integration-refwill use the feature branch instead ofmain.
Is this intentional? If this is temporary for testing, consider reverting before merge or updating the comment to reflect the actual default.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Recommendations
Files Reviewed (2 files)
|
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
Signed-off-by: Asish Kumar <[email protected]>
Describe the changes that are made
Links & References
Closes: #[issue number that will be closed through this PR]
🔗 Related PRs
🐞 Related Issues
📄 Related Documents
What type of PR is this? (check all applicable)
Added e2e test pipeline?
Added comments for hard-to-understand areas?
Added to documentation?
Are there any sample code or steps to test the changes?
Self Review done?
Any relevant screenshots, recordings or logs?
🧠 Semantics for PR Title & Branch Name
Please ensure your PR title and branch name follow the Keploy semantics:
📌 PR Semantics Guide
📌 Branch Semantics Guide
Examples:
fix: patch MongoDB document update bugfeat/#1-login-flow(You may skip mentioning the issue number in the branch name if the change is small and the PR description clearly explains it.)Additional checklist: