regexp: allow [\-] in unicode mode#226
Closed
sanish-bruno wants to merge 1 commit intojustjake:mainfrom
Closed
Conversation
5 tasks
Author
|
@justjake Hi, I see that quickjs-emscripten is lagging behind quick-js, in the regex file it self there are many changes that are not available on emscripten. will you be working on updating them. what is the usual process updating it? The PR i raised solves our usecase where we wanted to use ajvSchema within quickjs runtime. it will be helpful if you take a look at it? Is it possible to include the FIX in next release, so that we can plan our release accordingly? |
Owner
|
There is a command `yarn vendor:quickjs:pull` that I think will update
quickjs. You will need to change some #ifdef for the old version of
quickjs-ng still in tree. We should really just drop support for quickjs-ng
because I don't know how to cmake
…On Mon, Jun 23, 2025 at 3:04 AM sanish chirayath ***@***.***> wrote:
*sanish-bruno* left a comment (justjake/quickjs-emscripten#226)
<#226 (comment)>
@justjake <https://github.com/justjake> Hi, I see that quickjs-emscripten
is lagging behind quick-js, in the regex file it self there are many
changes that are not available on emscripten. will you be working on
updating them. what is the usual process updating it? The PR i raised
solves our usecase where we wanted to use ajvSchema within quickjs runtime.
it will be helpful if you take a look at it?
—
Reply to this email directly, view it on GitHub
<#226 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACIKV7EHGUEYFYZ5SK5JWL3E6RIVAVCNFSM6AAAAAB7XTPKQSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJVGE4TENBWGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Jake Teton-Landis
(805) 452-0701
***@***.***
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when we try to execute any code which has
\- and /ucombination with the regex, it causes issues within the sandbox. Similar change has been made to update thebellard/quick-jscommit