Update SCM module to handle invalid UTF-8 characters from git output#1492
Open
fuzzyrichie wants to merge 2 commits intodanger:masterfrom
Open
Update SCM module to handle invalid UTF-8 characters from git output#1492fuzzyrichie wants to merge 2 commits intodanger:masterfrom
fuzzyrichie wants to merge 2 commits intodanger:masterfrom
Conversation
In some cases, it seems that Danger will fail if the output contains a single character out of place, failing with "invalid byte sequence in UTF-8 (Encoding::CompatibilityError)" when running rstrip.
manicmaniac
reviewed
Jun 26, 2024
| git_command = string.split(" ").dup.unshift("git") | ||
| Open3.popen2(default_env, *git_command) do |_stdin, stdout, _wait_thr| | ||
| stdout.read.rstrip | ||
| stdout.read.scrub.rstrip |
Member
There was a problem hiding this comment.
@fuzzyrichie Sorry I don't understand what invalid UTF-8 character comes here.
Could you describe minimal steps to reproduce it, and add some test cases?
Author
There was a problem hiding this comment.
I'll look to get a sample of the output that caused the error, give me a day or two to set that up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, it seems that Danger will fail if the output contains a single character out of place, failing with "invalid byte sequence in UTF-8 (Encoding::CompatibilityError)" when running rstrip.